Added a way to turn ON and OFF Logs, just define BF_DEBUG on the prefix ... #9
Conversation
…ix file or add it on the compile macro
…delaying the set of the image to the UIImageView until the very last moment
| if (![self needsBetterFace]) { | ||
| return; | ||
| [self setBetterFaceImage:image]; |
There was a problem hiding this comment.
Actually, the setBetterFaceImage method should be moved at the first line in this function, because whatever you need BF or not, you should call setImage to let the UIImageView has the image instance to do other necessary things (such as showing the whole picture or saving it to your disk). You may hold the original image in the imageView instance to let it be easy to find.
There was a problem hiding this comment.
It seems that I mixed the pull request, I was trying a little "hack" to avoid the "blink" problem, the image starts normal then blinks to the proper ace AFTER the face was detected.
I'll fix this pull request and after that I'll send you a link for you to try my fix.
Do you have another example to stress test the library? Preferable one with a UITableView.
Sent from my iPhone
On 17/01/2014, at 22:09, Croath Liu notifications@github.com wrote:
In bf/bf/BetterFaceClass/UIImageView+BetterFace.m:
if (![self needsBetterFace]) {
return;[self setBetterFaceImage:image];—
Reply to this email directly or view it on GitHub.
|
I'm back on my mac! |
Added a way to turn ON and OFF Logs, just define BF_DEBUG on the prefix file or add it on the compile macro to turn it ON.
In the demo project I added it on the prefix file.