-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD.png still returns a CORS error #55
Comments
Interesting. I added a blanket nginx cors header for everything in the /static/ folder. So I don't know why it wouldn't be working for that one. |
Maybe that's somehow related?
Yes. When I changed my code to use
https://deckofcardsapi.com/static/img/aceDiamonds.png
for that 1 card, all 52 cards now load fine.
Thanks again.
Don
From: Chase Roberts <notifications@github.com>
Reply-To: crobertsbmw/deckofcards <reply@reply.github.com>
Date: Friday, October 19, 2018 at 3:54 PM
To: crobertsbmw/deckofcards <deckofcards@noreply.github.com>
Cc: Don Braffitt <don@willbraffitt.org>, Author <author@noreply.github.com>
Subject: Re: [crobertsbmw/deckofcards] AD.png still returns a CORS error (#55)
Interesting. I added a blanket nginx cors header for everything in the /static/ folder. So I don't know why it wouldn't be working for that one.
One other thing of note is that the api doesn't return AD.png but rather return aceDiamonds.png because ad blockers like to think that AD.png is an advertisement rather than the ace of diamonds. Maybe that's somehow related?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've got 51 of the 52 cards now loading correctly. Just one still returns a CORS error at test-cors.org:
https://deckofcardsapi.com/static/img/AD.png
Don
The text was updated successfully, but these errors were encountered: