Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json deserialization due to cert path handling #312

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

adamjanovsky
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 73.04% // Head: 72.96% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (8fb0687) compared to base (29ef79f).
Patch coverage: 89.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   73.04%   72.96%   -0.08%     
==========================================
  Files          45       45              
  Lines        5545     5601      +56     
==========================================
+ Hits         4050     4086      +36     
- Misses       1495     1515      +20     
Impacted Files Coverage Δ
src/sec_certs/sample/fips.py 86.88% <88.89%> (+0.05%) ⬆️
src/sec_certs/sample/cc.py 87.30% <90.00%> (+0.02%) ⬆️
src/sec_certs/dataset/fips_algorithm.py 66.28% <0.00%> (-15.11%) ⬇️
src/sec_certs/dataset/json_path_dataset.py 73.53% <0.00%> (-2.94%) ⬇️
src/sec_certs/utils/helpers.py 80.16% <0.00%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamjanovsky adamjanovsky merged commit a13e085 into main Feb 5, 2023
@adamjanovsky adamjanovsky deleted the fix/improve-path-setting-cert-internal-state branch February 5, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant