Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraction of certificate data. #389

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Add extraction of certificate data. #389

merged 6 commits into from
Feb 14, 2024

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Feb 7, 2024

This will fix #388.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (131489e) 69.61% compared to head (4592f97) 68.57%.

Files Patch % Lines
src/sec_certs/sample/cc.py 76.60% 44 Missing ⚠️
...ec_certs/model/references_nlp/segment_extractor.py 0.00% 3 Missing ⚠️
src/sec_certs/dataset/cc.py 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   69.61%   68.57%   -1.04%     
==========================================
  Files          62       62              
  Lines        7548     7565      +17     
==========================================
- Hits         5254     5187      -67     
- Misses       2294     2378      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY J08nY merged commit 8d6674a into main Feb 14, 2024
6 checks passed
@J08nY J08nY deleted the feat/process-certs branch February 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process certificates
1 participant