Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change skip intro and credit buttons #1950

Open
Shawn9347 opened this issue Mar 19, 2023 · 18 comments
Open

Change skip intro and credit buttons #1950

Shawn9347 opened this issue Mar 19, 2023 · 18 comments

Comments

@Shawn9347
Copy link

Hi,

the buttons for skip intro and skip credits look a little old fashioned IMO. Could you change it to a more modern looking button like plex itself has? And maybe an option to change the location if it's not too much to ask?

@Shawn9347 Shawn9347 changed the title Change skip intro and credit markers Change skip intro and credit buttons Mar 19, 2023
@croneter
Copy link
Owner

Sorry, this is front-end and thus COMPLETELY not my area 😢. Pull requests are always welcome though.

@Shawn9347
Copy link
Author

Okay, I can do that. Do you have an easy way to test changes? Or do I just start a tv show episode over and over again in kodi every time I make a change to the xml file? xD

@croneter
Copy link
Owner

Great! No sorry, you'll have to fire up Kodi again and again to test your changes.

@Shawn9347
Copy link
Author

Oh okay. I'll see what I can do when I find the time.

@m1dy
Copy link

m1dy commented Mar 19, 2023

@Shawn9347
script-plex-skip_marker.txt
That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits.
Maybe you can use this hack job as an inspiration.

@Shawn9347
Copy link
Author

Yea I found the file as well. Best would be that the button goes away after a few seconds and is visible whenever you open the player controls just like in plex.

@m1dy
Copy link

m1dy commented Mar 19, 2023

I wouldn't want the button to disappear completely. Always good to know that skipping is possible without having to open player controls.
Did try that before. Had the button go away after 5 seconds. Didn't like it as much as how I do it is now. Sometimes I wasn't sure I could skip because I didn't pay attention in the beginning.
Maybe you try my solution and see if you like it :)

@Shawn9347
Copy link
Author

Yea okay I will leave the functionality as is.

@Shawn9347
Copy link
Author

image

border doesn't work in this case. I don't know why yet. I would like to add rounded corners.

@croneter
Copy link
Owner

croneter commented Apr 6, 2023

Any progress here, @Shawn9347?

@Shawn9347
Copy link
Author

No sorry. I really haven't had any time to work on this.

@Shawn9347
Copy link
Author

Okay I have no clue how to fix this. This is totally not my specialty either. But, @croneter at least remove the shadow around the button. The width of the shadow is litteraly the entire screen so that's really annoying obviously.

It's this part.
<control type="group"> <height>64</height> <control type="image"> <width>100%</width> <height>64</height> <texture colordiffuse="44000000">skipintro-background.png</texture> </control>

@Shawn9347
Copy link
Author

@Shawn9347 script-plex-skip_marker.txt That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits. Maybe you can use this hack job as an inspiration.

This version has issues as well. There's a blue line across the text and no idea why.

@Shawn9347
Copy link
Author

@Shawn9347 script-plex-skip_marker.txt That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits. Maybe you can use this hack job as an inspiration.

How did you get that border effect? I want to make it less but none of the values in the code change the border.

@m1dy
Copy link

m1dy commented Oct 4, 2023

I don't see any border with my implementation.
Can you take a screenshot?

@thorindwarf
Copy link

May I ask you where do I have to put script-plex-skip_marker.txt in order to "deploy" it? :)

@m1dy
Copy link

m1dy commented Dec 15, 2023

@thorindwarf
just replace this file with it:
\addons\plugin.video.plexkodiconnect\resources\skins\default\1080i\script-plex-skip_marker.xml
notice that it should have .xml as the extension. I just uploaded it as .txt because github doesn't like xml for some reason

@thorindwarf
Copy link

Yep, I found it :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants