Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: using expect instead of ! operator #426

Closed
leejw51crypto opened this issue Apr 17, 2023 · 2 comments
Closed

Problem: using expect instead of ! operator #426

leejw51crypto opened this issue Apr 17, 2023 · 2 comments
Assignees
@leejw51crypto

Comments

@leejw51crypto
Copy link
Collaborator

in walletconnect.rs
new_client.
there is expect

  • icons.push(icon.parse().expect("url"));
  • url: url.parse().expect("url");

change to

  • icons.push(icon.parse()?);
  • url: url.parse()?;
@leejw51crypto leejw51crypto self-assigned this Apr 17, 2023
@leejw51crypto leejw51crypto mentioned this issue Apr 17, 2023
Open
@leejw51crypto
Copy link
Collaborator Author

also check other source, change expect -> ? operator
make sure only test code uses expect or only used as assert

@leejw51crypto
Copy link
Collaborator Author

working on

leejw51crypto added a commit to leejw51crypto/play-cpp-sdk that referenced this issue Apr 20, 2023
@leejw51crypto
Problem: using expect instead of ! operator (fix cronos-labs#426)
937b6e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leejw51crypto leejw51crypto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leejw51crypto