Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Fix to Search Block #167

Closed
wants to merge 1 commit into from
Closed

Title Fix to Search Block #167

wants to merge 1 commit into from

Conversation

liamkeily
Copy link
Contributor

This was causing the title to be displayed twice

This was causing the title to be displayed twice
@rchavik
Copy link
Member

rchavik commented May 13, 2013

Hi,

Can you describe the problem further? How would we get a title being displayed twice?

@liamkeily
Copy link
Contributor Author

By default when you install croogo the title for the search box is set to
not be displayed. When you change it to display the title there are 2
titles. After removing this line of code it only displayed one title.

I'm assuming there must be a title built into the block code somewhere?

On Mon, May 13, 2013 at 3:14 AM, Rachman Chavik notifications@github.comwrote:

Hi,

Can you describe the problem further? How would we get a title being
displayed twice?


Reply to this email directly or view it on GitHubhttps://github.com//pull/167#issuecomment-17790160
.

Liam Keily
Simply Websites UK
http://www.simplywebsites.com
liam@simplywebsites.com
07840528179 (Phone/Text)
Terms of Service http://www.simplywebsites.com/terms.pdf

http://www.linkedin.com/pub/liam-keily/54/6b7/a73

@rchavik
Copy link
Member

rchavik commented May 13, 2013

You're right.

The issue is that the block is rendered inside Blocks.Elements/block.ctp where it then outputs the first 'title', and the search.ctp outputs the second title.

Infact, we have duplicate block containers. Perhaps we need to go even further and remove everything in the search.ctp except the <form> tag and its children.

@rchavik rchavik closed this May 26, 2013
@rchavik
Copy link
Member

rchavik commented May 27, 2013

Can you resubmit and target master branch?

Thanks

rchavik added a commit to rchavik/croogo that referenced this pull request Jun 18, 2013
rchavik added a commit that referenced this pull request Jun 20, 2013
This reverts commit 3d2c177.
This commit was accidentally included when I pulled #166 when I
meant #167.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants