Small fixes #17
Closed
Small fixes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when preg_match_all parsed the following:
[e:myelement plugin="social" limit="1" random="true"]
$limit becomes: "1
Note: beginning single quote, missing end quote.
Regex updated as suggested by @StevenAFC in bakery comment.
propagate $block to actual element
By similar, I'm referring to having: - $block variable available to the element - respect 'Show Title' setting - have the element enclosed within html tags similar to croogo's block.ctp To achieve this, I have enabled Params behavior for Block model to allow user to specify 'enclosure' setting for given block. Default behavior is to have 'enclosure' be 'true'. Users can set this to false to disable automatic element enclosement.
|
merged to 1.3 branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.