Remove install-multilib.sh #91
Conversation
Using buildarg TARGETPLATFORM to install multilib where necessary.
There was a problem hiding this comment.
Acking this. I want to test this a bit, but it looks reasonable. @moto-timo
|
Tested local Would be nice to also test on Perhaps I'll spin up an |
| @@ -35,6 +34,7 @@ baseimage=`grep FROM Dockerfile | sed -e 's/FROM //'` | |||
| ${ENGINE_CMD} pull $baseimage | |||
|
|
|||
| ${ENGINE_CMD} build \ | |||
| --build-arg TARGETPLATFORM=$TARGETPLATFORM \ | |||
There was a problem hiding this comment.
I'm not sure this is necessary. When I use a regular docker build, this gets defined.
from ubuntu:20.04
ARG TARGETPLATFORM
RUN echo $TARGETPLATFORM$ docker --version
Docker version 20.10.12, build e91ed57
There was a problem hiding this comment.
This extends to the matrix additions and the -builder image below as well.
There was a problem hiding this comment.
I am not sure if podman or other supported container platforms do the same.
There was a problem hiding this comment.
FROM ubuntu:20.04
RUN env
HOSTNAME=<foo>
HOME=/root
PATH=<...>
PWD=/
So looks like docker implementations are not consistent... I had to pass in --build-arg TARGETPLATFORM=$(uname -m) to have something defined.
There was a problem hiding this comment.
What if you added ARG TARGETPLATFORM in the Dockerfile too?
If you were to use docker buildx build does that define TARGETPLATFORM? Since the build script supports other container platforms we probably couldn't remove it anyways since I don't think those platforms have the buildx command.
|
Just for grins: |
Using buildarg TARGETPLATFORM to install multilib where necessary.
I've been thinking about trying to get some cross architecture containers going and would like to fixup the build and deploy scripts and the GitHub workflow to better allow for that.
I chose to use
TARGETPLATFORMas a build argument asdocker buildxprovides it by default, which seems to be the only current option to get build cross-architecture containers. Since this project is only built for the linux/amd64 platform right now, I added that as the only option in the workflow job matrix.