Use direct container name lookup instead of link #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "-name" option to skydock to look up the skydns container by name. This avoids having to manage Docker container links. Docker's --link is still supported.
| @@ -40,6 +41,7 @@ var ( | |||
| func init() { | |||
| flag.StringVar(&pathToSocket, "s", "/var/run/docker.sock", "path to the docker unix socket") | |||
| flag.StringVar(&skydnsUrl, "skydns", "", "url to the skydns url") | |||
| flag.StringVar(&skydnsContainerName, "name", "", "name of skydns container") | |||
There was a problem hiding this comment.
this should default to skydns instead of an empty string
There was a problem hiding this comment.
If we do that, it means the old behavior will change. I'm fine with that, but are you? :-)
There was a problem hiding this comment.
ok, nevermind. we will be nice for now ;)
Closed
|
@crosbymichael are there any patterns to make linking easier or more automated? maybe being able to specify a link in the dockerfile itself could help? |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Apr 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "-name" option to skydock to look up the skydns container by name.
This avoids having to manage Docker container links.
Docker's --link is still supported.