SSH config souldn't be mandatory #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.Debugf("cannot find ssh config file: %s", path) | ||
| return sections, nil | ||
| } | ||
|
|
||
| log.Debugf("parsing ssh config file: %s", path) | ||
| content, err := ioutil.ReadFile(path) | ||
| if err != nil { |
There was a problem hiding this comment.
Instead of doing a stat above you can just handed the IsNotExist error here that will come from ReadFile.
if err != nil {
if os.IsNotExist(err) {
return make(map[string]*SshConfigFileSection), nil
}
return nil, err
}
|
Thanks for your feedback, much better now :) |
|
thanks! LGTM |
crosbymichael
added a commit
that referenced
this pull request
Feb 10, 2016
SSH config souldn't be mandatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, SSH config souldn't be mandatory if not provided by the end-user.