Handle :authority pseudo-header
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unblocks obtaining of Host when using HTTP/2 Cro server.
|
Seems like the dual of ddd7ff1, which I neglected to think of when I did that. Thanks! |
|
Hi, Thank you for picking this up! And explaining your steps on stackoverflow. I'm just getting acquainted with Cro. I can confirm this works perfectly now using Chrome. Chrome sends the :authority header under HTTP/2. My Mozilla Firefox (68.9.0esr (64-bit) on linux) however sends the Host header under HTTP/2 and this fix doesn't work for my firefox. Kind regards, |
|
Hi. I will try to look at it soon. The firefox issue sounds rather odd to me, because I am not sure RFC allows something like that, but OTOH firefox devs must be far better than me in doing this stuff, so we want to be compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks obtaining of Host when using HTTP/2 Cro server.
Related to https://stackoverflow.com/questions/62253651/how-to-get-the-host-or-authority-header-in-cro-when-using-http-2
acw++ for noticing and reporting.