Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a WebSocket client instance each time before connection #5

Closed
wants to merge 1 commit into from

Conversation

titsuki
Copy link
Contributor

@titsuki titsuki commented Mar 13, 2018

.connect isn't static method because it requires to lookup its attributes during the connection

.connect isn't static method because it requires to lookup its attributes during the connection
@jnthn
Copy link
Member

jnthn commented Mar 13, 2018

No, we shouldn't break existing tests. Using the type object is fine - with with Cro::HTTP::Client you only need to make an instance if you want configuration in the constructor that applies to add connections. If it is looking up attributes, it should guard that using with self { } and thus only do it if connect is called on an instance.

@titsuki
Copy link
Contributor Author

titsuki commented Mar 13, 2018

Thanks for your reply. I'll close this PR.

@titsuki titsuki closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants