Skip to content

Commit

Permalink
BrowserStack Tunnel v7 Errors Fix
Browse files Browse the repository at this point in the history
BrowserStack tunnel URL now provided v7 tunnel. It creates new processes
with 'fork-N' added to the identifier. This confused the Manager as it
now counts more than valid processes. Fixed Manager core logic to ignore
processes that have 'fork-N' in their tunnel identifier (if there is one).

Verified all 3 tunnels tests post the change.

Even SauceLabs has moved to 4.4.10 from 4.4.9. However; updating to that
fails the unit tests with what looks like some deep issues to solve. In
some unit tests, it is leading to a workflow where an HTTP Request is being
made without a URL. Kept the version to 4.4.9.

Updated ISSUE_TEMPLATE to include details of attachments.
  • Loading branch information
reeteshranjan committed Nov 27, 2017
1 parent 642a6f4 commit c568532
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
3 changes: 3 additions & 0 deletions ISSUE_TEMPLATE.md
Expand Up @@ -15,3 +15,6 @@

{Paste the log produced while running the relevant executable with LOG_LEVEL=DEBUG}

**Attachments**:

{Describe your attachments e.g. browser config .yml file, settings .json file, snapshot etc.}
10 changes: 6 additions & 4 deletions lib/platforms/core/manager.js
Expand Up @@ -50,10 +50,12 @@ function find(ProcessClass, command, tunnelIdArg) {
}
list.forEach(proc => {
let idx = proc.arguments.indexOf(tunnelIdArg)
found.push(new ProcessClass(
parseInt(proc.pid, 10),
(-1 !== idx ? proc.arguments[idx+1] : undefined)
))
if(-1 === idx || !proc.arguments[idx+1].match(/fork/)) {
found.push(new ProcessClass(
parseInt(proc.pid, 10),
(-1 !== idx ? proc.arguments[idx+1] : undefined)
))
}
})
resolve(found)
})
Expand Down

0 comments on commit c568532

Please sign in to comment.