Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csharp support #45

Merged
merged 13 commits into from
Apr 23, 2021
Merged

Csharp support #45

merged 13 commits into from
Apr 23, 2021

Conversation

jothepro
Copy link
Contributor

@jothepro jothepro commented Apr 18, 2021

Migrated C# support migrated from iit-reacts.

I have already migrated the support-lib and successfully executed the test-suite as well, a PR for that will come soon.

This PR is still WIP, because the documentation is not yet complete. I don't expect bigger code changes any more. I am looking forward to your feedback!

…new project structure

- add support for C++/CLI code generation
- update documentation
- update integration tests to include testing for C++/CLI
* add --cppcli-include-cpp-prefix parameter
* apply some IntelliJ IDEA Code Analysis warnings
* improve "generated code usage" documentation
* fix autogenerated header file header
…dows. This is helpful as CMake (which is eventually the tool that will process the file) cannot handle Windows paths.
@jothepro jothepro requested review from freitass and a4z April 18, 2021 17:03
@a4z
Copy link
Contributor

a4z commented Apr 18, 2021

wow !
just one problem, since I am rarely on windows, I am not sure when I can give that a run.
Johanne, aren't you a Mac user, do you run that with Dot Net Core , or on Windows ... ?

@jothepro
Copy link
Contributor Author

jothepro commented Apr 18, 2021

C++/CLI is not supported outside of Windows.

I am running this in a Windows VM on my Mac.

docs/idl.md Outdated Show resolved Hide resolved
src/main/scala/djinni/meta.scala Outdated Show resolved Hide resolved
src/main/scala/djinni/Main.scala Outdated Show resolved Hide resolved
@freitass
Copy link
Contributor

Super cool seeing new languages getting added to Djinni. C# is of special interest to me because it means we'll be able to use this repository on our product at work (which will probably lead to more improvements being submitted back). So thank you very much for this one @jothepro!

@jothepro jothepro marked this pull request as ready for review April 21, 2021 20:32
@jothepro
Copy link
Contributor Author

Ok I added the last missing details in the documentation. I am ready for your final review 👍

@a4z
Copy link
Contributor

a4z commented Apr 21, 2021

Awesome!
Just fear this will take me some serious amount of time since I am so rarely on Windows, and to seriously look at the changes I would need to checkout and run the code.
Lets hope Leandro is quicker than I (I know he looked already, but I would like to see his comments resolved)

Copy link
Contributor

@freitass freitass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jothepro jothepro merged commit a82dc9f into cross-language-cpp:main Apr 23, 2021
@jothepro jothepro deleted the csharp_support branch April 30, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants