Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ImagePlatform::architecture deduced from TargetTriple::Aarch64UnknownLinuxMusl #1253

Closed
2 of 11 tasks
tillrohrmann opened this issue May 9, 2023 · 0 comments · Fixed by #1254
Closed
2 of 11 tasks

Wrong ImagePlatform::architecture deduced from TargetTriple::Aarch64UnknownLinuxMusl #1253

tillrohrmann opened this issue May 9, 2023 · 0 comments · Fixed by #1254

Comments

@tillrohrmann
Copy link
Contributor

Checklist

Describe your issue

It seems that ImagePlatform::from_const_target sets the architecture for TargetTriple::Aarch64UnknownLinuxMusl to Architecture::Arm instead of Architecture::Arm64.

What target(s) are you cross-compiling for?

No response

Which operating system is the host (e.g computer cross is on) running?

  • macOS
  • Windows
  • Linux / BSD
  • other OS (specify in description)

What architecture is the host?

  • x86_64 / AMD64
  • arm32
  • arm64 (including Mac M1)

What container engine is cross using?

  • docker
  • podman
  • other container engine (specify in description)

cross version

cross 0.2.5

Example

No response

Additional information / notes

No response
@tillrohrmann tillrohrmann mentioned this issue May 9, 2023
Merged
bors bot added a commit that referenced this issue May 10, 2023
@bors @tillrohrmann
Merge #1254
54f5086 
1254: Fix ImagePlatform resolution r=Emilgardis a=tillrohrmann

Fix ImagePlatform resolution for `Aarch64UnknownLinuxMusl` to set the `architecture` to `Architecture::Arm64`.

This fixes #1253

Co-authored-by: Till Rohrmann <trohrmann@apache.org>
bors bot added a commit that referenced this issue May 10, 2023
@bors @tillrohrmann
Merge #1254
ee15e90 
1254: Fix ImagePlatform resolution r=Emilgardis a=tillrohrmann

Fix ImagePlatform resolution for `Aarch64UnknownLinuxMusl` to set the `architecture` to `Architecture::Arm64`.

This fixes #1253

Co-authored-by: Till Rohrmann <trohrmann@apache.org>
bors bot added a commit that referenced this issue May 10, 2023
@bors @tillrohrmann
Merge #1254
ccc0d4e 
1254: Fix ImagePlatform resolution r=Emilgardis a=tillrohrmann

Fix ImagePlatform resolution for `Aarch64UnknownLinuxMusl` to set the `architecture` to `Architecture::Arm64`.

This fixes #1253

Co-authored-by: Till Rohrmann <trohrmann@apache.org>
bors bot added a commit that referenced this issue May 12, 2023
@bors @tillrohrmann
Merge #1254
ca22136 
1254: Fix ImagePlatform resolution r=Emilgardis a=tillrohrmann

Fix ImagePlatform resolution for `Aarch64UnknownLinuxMusl` to set the `architecture` to `Architecture::Arm64`.

This fixes #1253

Co-authored-by: Till Rohrmann <trohrmann@apache.org>
@bors bors bot closed this as completed in 8a7e8ab May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ImagePlatform resolution tillrohrmann/cross
1 participant
@tillrohrmann