Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deb Subcommand #717

Closed
Alexhuszagh opened this issue May 25, 2022 · 0 comments · Fixed by #718
Closed

Remove deb Subcommand #717

Alexhuszagh opened this issue May 25, 2022 · 0 comments · Fixed by #718
Labels

Comments

@Alexhuszagh
Copy link
Contributor

The subcommand deb runs in the container, however, cargo-deb is not installed by default. Since we don't support similar subcommands like asm, it is probably worth removing this subcommand until we support other subcommands (#716). The relevant diff would be:

diff --git a/src/cargo.rs b/src/cargo.rs
index 14e9585..b22d427 100644
--- a/src/cargo.rs
+++ b/src/cargo.rs
@@ -15,7 +15,6 @@ pub enum Subcommand {
     Rustc,
     Test,
     Bench,
-    Deb,
     Clippy,
     Metadata,
 }
@@ -44,7 +43,6 @@ impl<'a> From<&'a str> for Subcommand {
             "rustc" => Subcommand::Rustc,
             "t" | "test" => Subcommand::Test,
             "bench" => Subcommand::Bench,
-            "deb" => Subcommand::Deb,
             "clippy" => Subcommand::Clippy,
             "metadata" => Subcommand::Metadata,
             _ => Subcommand::Other,
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue May 25, 2022
cargo-deb is not installed in the pre-built images, but `cross deb` runs
in docker rather than falling back to the host.

Closes cross-rs#717.
bors bot added a commit that referenced this issue May 25, 2022
718: Remove deb subcommand. r=Alexhuszagh a=Alexhuszagh

cargo-deb is not installed in the pre-built images, but `cross deb` runs in docker rather than falling back to the host.

Closes #717.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@bors bors bot closed this as completed in 773824b May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant