Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu version for {x86_64, i686}-unknown-linux-gnu docker images #270

Closed
wants to merge 3 commits into from

Conversation

Disasm
Copy link

@Disasm Disasm commented May 18, 2019

This should solve svd2rust CI build issues.

Also Rust uses Ubuntu 16.04 in x86_64-gnu-distcheck Docker image.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2019
@Disasm
Copy link
Author

Disasm commented May 18, 2019

(Yes, I know about this, but It's time to move forward)

@Dylan-DPC-zz
Copy link

bors: try

bors bot added a commit that referenced this pull request May 18, 2019
@Disasm
Copy link
Author

Disasm commented May 18, 2019

New problem here: https://github.com/rust-embedded/cross/blob/42fd2420fb7f568e10cd534725245df8ecae8904/ci/script.sh#L33-L43

error: failed to run custom build command for `compiler_builtins v0.1.15 (/project)`

Caused by:
  process didn't exit successfully: `/target/debug/build/compiler_builtins-c292f450b529b894/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=build.rs
cargo:compiler-rt=/project/compiler-rt

--- stderr
thread 'main' panicked at 'RUST_COMPILER_RT_ROOT is not set', build.rs:420:21
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Introduced 2 days ago: rust-lang/compiler-builtins#294
I have no idea how to fix this.

@bors
Copy link
Contributor

bors bot commented May 18, 2019

try

Build failed

@japaric
Copy link
Contributor

japaric commented May 21, 2019

Also Rust uses Ubuntu 16.04 in x86_64-gnu-distcheck Docker image.

This is not the docker image used to build the rust-std components. It's only used for testing.

The image used to build the rust-std components is this centos 5 image.

This should solve svd2rust CI build issues.

rust-embedded/svd2rust#297 should fix those

@Disasm
Copy link
Author

Disasm commented May 21, 2019

Ok, now at least we have an alternative. Thanks!

@Disasm Disasm closed this May 21, 2019
@Disasm Disasm deleted the update-dockerfiles-x86 branch May 21, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants