Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86_64-unknown-illumos target. #913

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

Alexhuszagh
Copy link
Contributor

Also reduces the size of the Solaris and FreeBSD images by ~80MB. Closes #539.

@Alexhuszagh
Copy link
Contributor Author

Illumos is tier 2 target, and very close to Solaris and the builds are quite easy (except for the lack of C++ support), so I believe it's worthy of inclusion. I'm currently keeping this as a draft because I haven't done extensive testing yet and it needs a CHANGELOG entry.

@Alexhuszagh Alexhuszagh force-pushed the illumos branch 3 times, most recently from 8738806 to 696af6e Compare July 6, 2022 19:08
@Alexhuszagh

This comment was marked as outdated.

bors bot added a commit that referenced this pull request Jul 6, 2022
Also reduces the size of the Solaris images by ~80MB.
@bors

This comment was marked as outdated.

@Alexhuszagh
Copy link
Contributor Author

bors try --target x86_64-unknown-illumos

bors bot added a commit that referenced this pull request Jul 6, 2022
@bors
Copy link
Contributor

bors bot commented Jul 6, 2022

try

Build succeeded:

@Alexhuszagh Alexhuszagh marked this pull request as ready for review July 6, 2022 19:41
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner July 6, 2022 19:41
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Missing a readme entry, otherwise lgtm!

@Alexhuszagh
Copy link
Contributor Author

Updated the README to contain an entry and target-info to handle Illumos-based images.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 7, 2022

Build succeeded:

@bors bors bot merged commit ee96faa into cross-rs:main Jul 7, 2022
@Alexhuszagh Alexhuszagh deleted the illumos branch July 7, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for illumos (tier 2 platform)
2 participants