Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dind test #925

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix dind test #925

merged 1 commit into from
Jul 8, 2022

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Jul 8, 2022 •
edited

same as #924

also fixes no subs on variable passthrough

@Emilgardis Emilgardis requested a review from a team as a code owner July 8, 2022 18:22
@Alexhuszagh Alexhuszagh added the no changelog A valid PR without changelog (no-changelog) label Jul 8, 2022
@Alexhuszagh
Copy link
Contributor

This probably also needs to be done in test-remote and test-bisect.

@Emilgardis
fix dind test
258701a 
same as cross-rs#924

also fixes no subs on variable passthrough
@Emilgardis
Copy link
Member Author

bisect and remote dont need it since it's using a binary with the data needed for cross to determine that it should use main

https://github.com/cross-rs/cross/runs/7256289776?check_suite_focus=true

@Emilgardis
Copy link
Member Author

bors r=@Alexhuszagh

@bors
Copy link
Contributor

bors bot commented Jul 8, 2022

Build succeeded:

@bors bors bot merged commit 3d6a52a into cross-rs:main Jul 8, 2022
@Emilgardis Emilgardis deleted the fix-dind branch July 8, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Emilgardis @Alexhuszagh