Chore: Improvement on config templates #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricionaweb
commented
May 15, 2023
src/config.template.docker.cjs
Outdated
| @@ -170,6 +170,7 @@ module.exports = { | |||
| /** | |||
| * Bind to a specific host address. | |||
| * Example: "127.0.0.1" | |||
| * Default is "0.0.0.0" | |||
There was a problem hiding this comment.
I checked in nodejs docs, when undefined 0.0.0.0 is default.
If host is omitted, the server will accept connections on the unspecified IPv6 address (::) when IPv6 is available, or the unspecified IPv4 address (0.0.0.0) otherwise.
https://nodejs.org/api/net.html#serverlistenport-host-backlog-callback
fabricionaweb
commented
May 15, 2023
| * For Jackett, click "Copy RSS feed" | ||
| * For Prowlarr, click (i) and copy the Torznab Url, then append "?apikey=YOUR_PROWLARR_API_KEY" | ||
| * For Prowlarr, click on the indexer name and copy the Torznab Url, then append "?apikey=YOUR_PROWLARR_API_KEY" |
There was a problem hiding this comment.
Prowlarr has changed, it does not have the (i) anymore. Instead you need to click at indexer name (first column)
fabricionaweb
force-pushed
the
chore-templates
branch
from
44d7c6d
to
5bdb4c3
Compare
|
thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small touches that I think can look better