-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Search limit #418
Conversation
c53efff
to
d202792
Compare
d202792
to
180ee47
Compare
i actually removed a what if we had a way for cross-seed to automatically balance? example: searchCadence 1 day, excludeRecentSearch is 6 months (~180 days), we're running for the first time. 1000 torrents are eligible to run. therefore, we do one 180th of the torrents, plus some number for good measure. one problem with this approach would be that as we progress through the 6 months, less and less torrents will be eligible to run. when there are 89 torrents left, a 180th of the eligible torrents would round to 0. so the first time, we'd do like 5, and towards the end we'd be doing less. So it's not fully balanced. Another approach: we count the total number of torrents, ignoring excludeRecentSearch, then divide that number by 180. Then, we run that number of torrents today (rounding up). this would probably be the most balanced? and it does seem feasible… |
180ee47
to
021dc76
Compare
I was chatting to fab about this - that last idea sounds like it would work. So, you could just have an |
yeah i think so. |
021dc76
to
0b16355
Compare
Thank you for the contribution! |
The idea here is to limit the number of queries to be made between each running.
The current feature
excludeRecentSearch
can already filter off some results, so combined with a limit feature we can have more flexibility.Example of my usage:
excludeRecentSearch
set to5 days
searchLimit
set to100
searchCadence
set to1 day
Every day the search runs, it picks only the 100 that have not be done before
The user needs to pay attemption of their values or this can keep items out of the search, for example, if the
excludeRecentSearch
is too short for the limit, it will be start to pick items again...fixes #432