Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tag image with semver compliant container tag #434

Merged
merged 3 commits into from
Jun 26, 2023
Merged

chore: tag image with semver compliant container tag #434

merged 3 commits into from
Jun 26, 2023

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Jun 10, 2023

Hi 馃憢馃徏

I don't see a reason to have the version- prefix on this tag but curious to know if there was a reason for it :)

This changes also makes it easier for automation tools like Renovate that expect semver to automatically sort and filter the tag correctly.

Thanks!

Hi 馃憢馃徏 

I don't see a reason to see the `version-` prefix on this tag but curious to know if there was a reason for it :)

This changes also makes it easier for automation tools like Renovate that expect semver to automatically sort and filter the tag correctly.

Thanks!
@mmgoodnow
Copy link
Collaborator

mmgoodnow commented Jun 25, 2023

can we keep the old format but add the new format so it's backwards compatible?

@onedr0p
Copy link
Contributor Author

onedr0p commented Jun 25, 2023

Sure... but what's the need on having both? Having one tag keeps things simple.

@mmgoodnow
Copy link
Collaborator

Backwards compatibility.

@onedr0p
Copy link
Contributor Author

onedr0p commented Jun 25, 2023

Yeah... I read that, but I don't understand. How does keeping the old tag format keep backwards compatibility?

@mmgoodnow
Copy link
Collaborator

People already using version- tags can continue to do so without having to change anything.

@mmgoodnow
Copy link
Collaborator

e.g. when they're updating their container version, and then they change to version-6 but it doesn't exist. so then they need to debug

@onedr0p
Copy link
Contributor Author

onedr0p commented Jun 25, 2023

I read the metadata action docs but I'm not seeing a way to have both. Honestly I don't see why this matters but I'll keep looking into it and report back. I just added support for multiple tags which also should help people who just want to pinned to the latest major, minor or full semver tags.

1.2.3
1.2
1

@onedr0p
Copy link
Contributor Author

onedr0p commented Jun 25, 2023

Nevermind the latest commit should do it.

@mmgoodnow
Copy link
Collaborator

thanks for adding the major version tags! that'll be a nice QOL improvement 馃檪

@mmgoodnow mmgoodnow merged commit 5f26655 into cross-seed:master Jun 26, 2023
@onedr0p onedr0p deleted the patch-1 branch June 26, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants