-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tag image with semver compliant container tag #434
Conversation
Hi 馃憢馃徏 I don't see a reason to see the `version-` prefix on this tag but curious to know if there was a reason for it :) This changes also makes it easier for automation tools like Renovate that expect semver to automatically sort and filter the tag correctly. Thanks!
can we keep the old format but add the new format so it's backwards compatible? |
Sure... but what's the need on having both? Having one tag keeps things simple. |
Backwards compatibility. |
Yeah... I read that, but I don't understand. How does keeping the old tag format keep backwards compatibility? |
People already using |
e.g. when they're updating their container version, and then they change to |
I read the metadata action docs but I'm not seeing a way to have both. Honestly I don't see why this matters but I'll keep looking into it and report back. I just added support for multiple tags which also should help people who just want to pinned to the latest major, minor or full semver tags.
|
Nevermind the latest commit should do it. |
thanks for adding the major version tags! that'll be a nice QOL improvement 馃檪 |
Hi 馃憢馃徏
I don't see a reason to have the
version-
prefix on this tag but curious to know if there was a reason for it :)This changes also makes it easier for automation tools like Renovate that expect semver to automatically sort and filter the tag correctly.
Thanks!