Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobsByOrganizationAPI should return JSON by default, JSON-P via Parameter #477

Closed
mbo-s opened this issue Sep 4, 2018 · 2 comments
Closed

JobsByOrganizationAPI should return JSON by default, JSON-P via Parameter #477

mbo-s opened this issue Sep 4, 2018 · 2 comments

Comments

@mbo-s
Copy link

mbo-s commented Sep 4, 2018

Currently the jobapi returns JSON-P with a hardcoded yawikParseJobs
https://github.com/cross-solution/YAWIK/blob/develop/module/Jobs/src/Jobs/Controller/ApiJobListByOrganizationController.php#L45
e.g.
https://yawik.org/demo/de/api/jobs/organization/55ae775c6b10f8f05b8b457f

Is it possible to return by default only JSON and JSON-P via a dynamic callback Parameter e.g.
https://yawik.org/demo/de/api/jobs/organization/55ae775c6b10f8f05b8b457f?callback=mycallbackfunction

@TiSiE what do you think?
cbleek added a commit that referenced this issue Sep 6, 2018
@cbleek
adds callback name to the api/jobs/organization route (gh-477)
f3b89c8
@cbleek
Copy link
Member

cbleek commented Sep 6, 2018

this is much better than the current hardcoded callback name.

I've implemented the callback name as an additional
route parameter.

So an URL will look like api/jobs/organization/55ae775c6b10f8f05b8b457f/myCallBack

@coveralls coveralls mentioned this issue Sep 6, 2018
Merged
cbleek added a commit that referenced this issue Sep 6, 2018
@cbleek
adds callback name to the api/jobs/organization route (gh-477) (#479)
71499f2 
* adds "callback" as a query parameter (gh-477)
* adds unittest
* renames $sm to $serviceManager
@cbleek
Copy link
Member

cbleek commented Sep 6, 2018

Works now as requested

@cbleek cbleek closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbleek @mbo-s