Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader for purge expire jobs should consider "dateModified" #579

Closed
TiSiE opened this issue Jun 30, 2020 · 1 comment
Closed

Loader for purge expire jobs should consider "dateModified" #579

TiSiE opened this issue Jun 30, 2020 · 1 comment
Assignees
@TiSiE
Labels
Jobs optimization

Comments

@TiSiE
Copy link
Member

TiSiE commented Jun 30, 2020

Currently, the loader for the purge expire jobs action checks against the "datePublishEnd" or - if not available - "dateCreated".

It certainly makes more sense to check against the "dateModified".
@TiSiE TiSiE self-assigned this Jun 30, 2020
@cbleek
Copy link
Member

cbleek commented Jul 1, 2020

@kilip dateCreated has to be changed to dateModified. Maybe Tests have to be adjusted.

see:

TiSiE added a commit that referenced this issue Jul 2, 2020
@TiSiE
Merge pull request #580
c1a6aa2 
* pr-580:
  [node] removed chromedriver from dev dependencies
  [Jobs] added functional tests for LoadExpiredJobsToPurge, ref #579
  [Jobs] fixed purged jobs using dateModified instead of dateCreated, ref #579
  [Core] changed deprecated base class DocumentRepository
@TiSiE TiSiE closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TiSiE TiSiE

Labels
Jobs optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbleek @TiSiE