Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] separated dashboard from index page ref #460 #463

Merged
merged 1 commit into from Feb 12, 2018
Merged

[Core] separated dashboard from index page ref #460 #463

merged 1 commit into from Feb 12, 2018

Conversation

kilip
Copy link
Collaborator

@kilip kilip commented Feb 12, 2018

  • added LazyControllerFactory to create controller
  • added behat features to tests dashboard and index page

@kilip
[Core] separated dashboard from index page
b9b48a0 
* added LazyControllerFactory to create controller
* added behat features to tests dashboard and index page
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 43.999% when pulling b9b48a0 on kilip:gh-460 into 3062c07 on cross-solution:develop.

@TiSiE TiSiE self-requested a review February 12, 2018 14:03
@TiSiE TiSiE merged commit b9b48a0 into cross-solution:develop Feb 12, 2018
TiSiE added a commit that referenced this pull request Feb 12, 2018
@TiSiE
Merge pull request #463: Separates Start/Index page and dashboard.
09456b0 
* pr-463:
  [Core] separated dashboard from index page * added LazyControllerFactory to create controller * added behat features to tests dashboard and index page
  [Behat] fixed behat steps
  [Behat] fixed behat steps
  [CI] removed mail configuration for development option
  [Behat] fixed creating job draft scenario
  [CI] added missing MailContext
  [CI] fixed FileTransport directory in travis env
  [CI] removed mail tag from behat filter
  [CI] configured mail to use FileTransport in travis environment
  [Core] added test for Core\Mail\StringTemplateMessage
  [Core] added test for Core\Mail\Message
  [Core] removed unused class from declaration
  [Behat] added MailContext to test mailing functionality in scenario
  [Core] added FileTransport to be used for test mailing functionality
  [Core] added new FileTransport to be used for test mailing functionality
@kilip kilip deleted the gh-460 branch February 13, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiSiE TiSiE TiSiE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kilip @coveralls @TiSiE