Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify application notifications #28

Closed
TiSiE opened this issue Mar 31, 2014 · 0 comments
Closed

Unify application notifications #28

TiSiE opened this issue Mar 31, 2014 · 0 comments
Assignees
Milestone

Comments

@TiSiE
Copy link
Member

TiSiE commented Mar 31, 2014

Currently the various notifications the application displays on the site are very chaotic.
e.g. if a job application is saved, the notification is displayed underneath the headline, but if one logged out, the notification is displayed above the headline.
Internally (in the code), the notifications are handled different.
As view variable, as flash message (session based).

The goal is, to unify the notification management, to reduce code duplication and ease the development process.

The idea is to only use session based notifications based upon the ZF2 FlashMessenger. But to further enhance it by providing a new Controller-Plugin and View Helper Plugin, to simplify it even more.
Notifications will be rendered by attaching a child view model to the layout, to allow other modules to alter the way, the notifications are displayed.

@TiSiE TiSiE added this to the v0.11 milestone Mar 31, 2014
@TiSiE TiSiE self-assigned this Mar 31, 2014
TiSiE added a commit that referenced this issue Apr 7, 2014
* Adds Controller Plugin (enhancement of FlashMessenger)
* Adds View Script to render notifications (through Model injected by a listener to
  the render event.)
* Adds View Helper to render Alert boxes.
* Refactors HeadscriptInitializer to HeadscriptFactory
  (allows for route-aware script injection via config file)

(refs gh-28, #5101)
@TiSiE TiSiE closed this as completed Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant