-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary object to Base64 support #189
Comments
This isn't implemented yet. But since the refactoring of serializers, this could now be done at one place: https://github.com/crossbario/autobahn-js/blob/master/package/lib/serializer.js#L22
|
In fact, we've just recently implemented this in AutobahnPython and Crossbar.io. Which finally allows to fix this here too, since we can now test the feature. |
Would it make sense to be able to configure base64 as a serializer for the REST bridge? This seems like it would be handy because unless I am missing something, a method written to return some binary can currently not be called via REST bridge, only over websocket. |
@chrisbarber yes, that would make sense: crossbario/crossbar#1079 When this is done, then AB JS needs bits too. But the issue here is to add support for transparent binaries over JSON in AB JS over regular transports (WebSocket/RawSocket) .. |
there now is CI test coverage for binary payloads via https://github.com/crossbario/autobahn-js/blob/master/test/test_binary.js to activate the tests for json, uncomment this: Line 60 in caa775a
|
Does autobahn-js support conversion of binary objects to Base64, as per section 14 of the WAMP spec?
If a Base64 string were manually constructed with a leading '\0', and passed as an RPC argument, would it break Autobahn|JS?
The text was updated successfully, but these errors were encountered: