Fixed a bug, where wss implies tls client authentication #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddjobz
reviewed
Oct 29, 2018
|
Is there anything new with this? |
|
IMHO, this is a relativly critical bug and should be fixed. |
|
@johannwagner I understand its important but I think we can use the moment to improve the logging a bit. If you are fine I can quickly create a PR against your branch to implement the above suggestion of mine and then we can land it. |
|
I am completly fine with this, feel free 👌 |
|
Landed the change, thanks for the bug fix and sorry that took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387