Nothrow on leave notjoined (#1542)

* do not throw (but log) when leaving a session that is not joined
* never default set authid/authrole in component authenticators
* bump dev version
* update changelog

autobahn/_version.py

@@ -24,6 +24,6 @@
 #
 ###############################################################################
 
-__version__ = '22.4.1.dev1'
+__version__ = '22.4.1.dev2'
 
 __build__ = '00000000-0000000'

autobahn/wamp/protocol.py

@@ -36,7 +36,7 @@
 from autobahn.wamp import types
 from autobahn.wamp import role
 from autobahn.wamp import exception
-from autobahn.wamp.exception import ApplicationError, ProtocolError, SessionNotReady, SerializationError, TypeCheckError
+from autobahn.wamp.exception import ApplicationError, ProtocolError, SerializationError, TypeCheckError
 from autobahn.wamp.interfaces import ISession, IPayloadCodec, IAuthenticator  # noqa
 from autobahn.wamp.types import SessionDetails, CloseDetails, EncodedPayload
 from autobahn.exception import PayloadExceededError
@@ -1364,7 +1364,8 @@ def leave(self, reason=None, message=None):
         Implements :meth:`autobahn.wamp.interfaces.ISession.leave`
         """
         if not self._session_id:
-            raise SessionNotReady("session hasn't joined a realm")
+            self.log.warn('session is not joined on a realm - no session to leave')
+            return
 
         if not self._goodbye_sent:
             if not reason:
@@ -1804,8 +1805,8 @@ def onConnect(self):
             self.join(
                 self.config.realm,
                 authmethods=list(self._authenticators.keys()),
-                authid=authid or 'public',
-                authrole=authrole or 'default',
+                authid=authid,
+                authrole=authrole,
                 authextra=authextra,
             )
         else:
@@ -1816,8 +1817,9 @@ def onChallenge(self, challenge):
             authenticator = self._authenticators[challenge.method]
         except KeyError:
             raise RuntimeError(
-                "Received challenge for unknown authmethod '{}'".format(
-                    challenge.method
+                "Received challenge for unknown authmethod '{}' [authenticators={}]".format(
+                    challenge.method,
+                    str(sorted(self._authenticators.keys()))
                 )
             )
         return authenticator.on_challenge(self, challenge)
@@ -1830,8 +1832,9 @@ def onWelcome(self, msg):
             authenticator = self._authenticators[msg.authmethod]
         except KeyError:
             raise RuntimeError(
-                "Received onWelcome for unknown authmethod '{}'".format(
-                    msg.authmethod
+                "Received onWelcome for unknown authmethod '{}' [authenticators={}]".format(
+                    msg.authmethod,
+                    str(sorted(self._authenticators.keys()))
                 )
             )
         return authenticator.on_welcome(self, msg.authextra)

docs/changelog.rst

@@ -5,6 +5,13 @@
 Changelog
 =========
 
+22.4.1.devX
+-----------
+
+* fix: never default set authid/authrole in component authenticators
+* fix: do not throw (but log) when leaving a session not joined
+* fix: store WAMP authextra received
+
 22.3.2
 ------