Skip to content

Commit

Permalink
consider 'wamp.close.goodbye_and_out' a clean exit (#1450)
Browse files Browse the repository at this point in the history
* consider 'wamp.close.goodbye_and_out' a clean exit

* add changelog

* more-real 'fix' I guess to placate Tox
  • Loading branch information
meejah committed Jan 25, 2021
1 parent a468e57 commit ce1c429
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion autobahn/wamp/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ def on_leave(session, details):
details=details,
)
if not txaio.is_called(done):
if details.reason in ["wamp.close.normal"]:
if details.reason in ["wamp.close.normal", "wamp.close.goodbye_and_out"]:
txaio.resolve(done, None)
else:
f = txaio.create_failure(
Expand Down
1 change: 1 addition & 0 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ master
------

* fix: add missing jinja2 dependency for XBR CLI (#1447)
* fix: ``wamp.close.goodbye_and_out`` counts as a clean exit (#1370)

20.12.3
-------
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ extras =
commands =
python -V
sphinx-build --version
python -c "from autobahn import xbr; print('HAS_XBR={:}'.format(xbr.HAS_XBR))"
python -c "from autobahn import xbr; print('HAS_XBR=' + str(xbr.HAS_XBR))"

# first test with all warnings fatal
find ./docs -name "*.rst"
Expand Down

0 comments on commit ce1c429

Please sign in to comment.