Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationSession.leave() doesn't appear to pass along reason or log_message #695

Closed
FirefighterBlu3 opened this issue Jun 27, 2016 · 3 comments

Comments

@FirefighterBlu3
Copy link

this call:

session.leave('wamp.close.logout', 'logged out')

with this callback:

    def onLeave(self, *args, **kwargs):
        # since we overrode the built in onLeave, we need to call
        # disconnect ourselves.
        # also, autobahn-python's .leave() method doesn't
        # propagate the reason or log_message, #todo, file bug
        print('shit papi, onLeave:',args[0].reason,kwargs)
        if not args[0].reason == 'wamp.close.normal':
            print('unexpected communication loss from router:',args[0].reason,kwargs)
        self.disconnect()

results in this output:

shit papi, onLeave: wamp.close.normal {}

this is different from autobahn-js where .leave(x, y) does result in the correct reason=x value

@meejah
Copy link
Contributor

meejah commented Jul 1, 2016

There does indeed appear to be an issue with crossbar here (although I don't get quite the behavior above, I also don't see the correct reason propagated).

@meejah
Copy link
Contributor

meejah commented Jul 12, 2016

see crossbario/crossbar#830

@meejah
Copy link
Contributor

meejah commented Jan 19, 2021

I believe this is fixed in crossbar; please re-open if that's not true.

@meejah meejah closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants