Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivate websocket opening and ping/pong timeouts - there is sth wr… #1130

Closed
wants to merge 1 commit into from

Conversation

oberstet
Copy link
Contributor

@oberstet oberstet commented Mar 5, 2019

…ong ..

@oberstet
Copy link
Contributor Author

oberstet commented Mar 6, 2019

The unit tests for websocket ping/pong fail (expected), like this autobahn.websocket.test.test_protocol.WebSocketServerProtocolTests.test_auto_ping

@meejah
Copy link
Contributor

meejah commented Mar 25, 2019

I don't understand; what is the problem?

@oberstet
Copy link
Contributor Author

I'm not exactly sure .. I have left this PR (not to be merged) as a reminder to investigate. what I observed is: under high load (in particular many new connections/sec), connections sometimes get killed by the timeout very soon / right after the connection is finally established. I deactivated the timeouts in my testing, and that "solved" the problem. Connections succeed.

My best guess at how we might reproduce: we need a load test that creates many new connections/sec, keeping each for say a couple of ping/pong cycles, and driving up the load so that the router worker is at 100% CPU

@oberstet oberstet closed this Jan 9, 2020
@oberstet oberstet deleted the deactivated_timeouts branch December 19, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants