fix handling of some TLS options in Component configs #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
- Coverage 62.93% 62.91% -0.02%
==========================================
Files 73 73
Lines 12512 12516 +4
Branches 1975 1976 +1
==========================================
+ Hits 7874 7875 +1
- Misses 3981 3984 +3
Partials 657 657
Continue to review full report at Codecov.
|
oberstet
reviewed
Jun 9, 2017
| @@ -193,7 +194,7 @@ def _create_transport_endpoint(reactor, endpoint_config): | |||
| if endpoint_config['type'] == 'tcp': | |||
|
|
|||
| version = int(endpoint_config.get('version', 4)) | |||
| host = str(endpoint_config['host']) | |||
| host = six.text_type(endpoint_config['host']) | |||
There was a problem hiding this comment.
actually, I think it would be much better not to coerce the type, but to raise if the user does not provide a string. no type coercions at all (we had that, and it was painful to remove again).
|
merged via #850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.