Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements-min.txt: remove idna. #1406

Closed
wants to merge 1 commit into from
Closed

requirements-min.txt: remove idna. #1406

wants to merge 1 commit into from

Conversation

asafkahlon
Copy link

A short "git grep idna" shows there's no direct use in idna
in crossbar.

Signed-off-by: Asaf Kahlon asafka7@gmail.com

@asafkahlon
requirements-min.txt: remove idna.
6c3e560 
A short "git grep idna" shows there's no direct use in idna
in crossbar.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
@codecov-io
Copy link

codecov-io commented Sep 26, 2018 •
edited
Loading

Codecov Report

Merging #1406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1406   +/-   ##
======================================
  Coverage    37.3%   37.3%           
======================================
  Files          78      78           
  Lines       11641   11641           
  Branches     2136    2136           
======================================
  Hits         4343    4343           
  Misses       6891    6891           
  Partials      407     407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2b674...6c3e560. Read the comment docs.

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this pull request Oct 4, 2018
@asafkahlon @tpetazzoni
python-crossbar: bump to version 18.9.2
9adc5dd 
Update dependencies (and fix alphabetical order).
Add patch to remove idna direct dependency (was sent to upstream too:
crossbario/crossbar#1406).

Fixes:
http://autobuild.buildroot.org/results/31d/31db5fd90514906a8c77f921c9650a386ec80101/

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
@oberstet
Copy link
Contributor

this is a recommended depdendency for use of TLS with Twisted. pls see the note here https://twisted.readthedocs.io/en/twisted-18.7.0/core/howto/ssl.html#connecting-to-public-servers

To properly validate your hostname parameter according to RFC6125, please also install the “service_identity” and “idna” packages from PyPI. Without this package, Twisted will currently make a conservative guess as to the correctness of the server’s certificate, but this will reject a large number of potentially valid certificates. service_identity implements the standard correctly and it will be a required dependency for TLS in a future release of Twisted.

@oberstet oberstet closed this Oct 19, 2018
@asafkahlon
Copy link
Author

OK, I guess can agree with that... But is there any reason to hold the idna version under 2.6 as stated at the requirements file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asafkahlon @codecov-io @oberstet