Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay here's how it looks for having "an API object". Sorry the diffs are huge -- but most of it is re-indenting.
The upshot is: we add one new public method ("with_config()" I've called it for now) and all existing code will work as-is. Anyone wanting "multiple custom configs" (which is only "loop" arg anyway) changes their code. So if you have code like:
Then you change it to look like this:
...and if you wanted a custom loop in
Foo
, then you setfoo.txa = txaio.with_config(loop=custom_loop)
and you're good. So essentially a two-step way to "buy in" to the custom-loop API:obj
attribute.Very open to suggestions for the "with_config" method-name!