Rewrite SegQueue for better performance #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
bors r+ |
Merge conflict (retrying...) |
1 similar comment
Merge conflict (retrying...) |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 21, 2019
291: Rewrite SegQueue for better performance r=stjepang a=stjepang The implementation of `SegQueue<T>` is completely rewritten and is based on https://github.com/stjepang/queue, which provides notably better performance. This one doesn't use `crossbeam-epoch` for memory reclamation, which means we don't have to pin and execute a full fence on every operation. For more information on how this queue works, see: * https://github.com/stjepang/queue/issues/1 * #279 (comment) One new addition in this PR is the `SegQueue::len()` method. Benchmarks before: ``` unbounded_mpmc Rust segqueue 0.336 sec unbounded_mpsc Rust segqueue 0.261 sec unbounded_seq Rust segqueue 0.306 sec unbounded_spsc Rust segqueue 0.201 sec ``` Benchmarks after: ``` unbounded_mpmc Rust segqueue 0.186 sec unbounded_mpsc Rust segqueue 0.206 sec unbounded_seq Rust segqueue 0.241 sec unbounded_spsc Rust segqueue 0.115 sec ``` Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
Build succeeded |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
SegQueue<T>is completely rewritten and is based on https://github.com/stjepang/queue, which provides notably better performance. This one doesn't usecrossbeam-epochfor memory reclamation, which means we don't have to pin and execute a full fence on every operation.For more information on how this queue works, see:
One new addition in this PR is the
SegQueue::len()method.Benchmarks before:
Benchmarks after: