Migrate to Rust 2018 #511
Merged
Migrate to Rust 2018 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeehoonkang
reviewed
May 22, 2020
taiki-e
force-pushed
the
rust-2018
branch
2 times, most recently
from
fe15353
to
4ccc1bb
Compare
taiki-e
force-pushed
the
rust-2018
branch
3 times, most recently
from
b8c375f
to
6eb65a4
Compare
Old cfg-if and memoffset don't support `use` imports.
|
Thanks! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates all crates to Rust 2018.
The first commit contains the minimal changes needed for the migration. This was mainly done by
cargo fix --editon.The second commit migrates the code to be the Rust 2018 idiomatic style. This mainly based on suggestions from
rust_2018_idiomslint.