Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB in destroy_array test #580

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fix UB in destroy_array test #580

merged 1 commit into from
Oct 9, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 9, 2020

Reportrd by Miri in #578 (log)

let mut v = Vec::with_capacity(COUNT);
for i in 0..COUNT {
v.push(i as i32);
}
let ptr = v.as_mut_ptr() as usize;
let len = v.len();
guard.defer_unchecked(move || {
drop(Vec::from_raw_parts(ptr as *const u8 as *mut u8, len, len));
DESTROYS.fetch_add(len, Ordering::Relaxed);
});

ptr is a pointer to Vec<i32>, but deallocated as Vec<u8>.

@jeehoonkang
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 9, 2020

Build succeeded:

@bors bors bot merged commit 5ea6e70 into master Oct 9, 2020
@bors bors bot deleted the epoch-test-ub branch October 9, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants