Fix newly added clippy warnings #927

taiki-e · 2022-11-17T03:05:42Z

error: deref which would be done by auto-deref
   --> crossbeam-utils/src/sync/wait_group.rs:142:29
    |
142 |         let count: &usize = &*self.inner.count.lock().unwrap();
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner.count.lock().unwrap()`
    |
    = note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

``` error: deref which would be done by auto-deref --> crossbeam-utils/src/sync/wait_group.rs:142:29 | 142 | let count: &usize = &*self.inner.count.lock().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner.count.lock().unwrap()` | = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref ```

taiki-e · 2022-11-17T03:05:49Z

bors r+

927: Fix clippy::explicit_auto_deref warning r=taiki-e a=taiki-e ``` error: deref which would be done by auto-deref --> crossbeam-utils/src/sync/wait_group.rs:142:29 | 142 | let count: &usize = &*self.inner.count.lock().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner.count.lock().unwrap()` | = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref ``` Co-authored-by: Taiki Endo <te316e89@gmail.com>

bors · 2022-11-17T03:28:27Z

Build failed:

test (aarch64-unknown-linux-gnu)

``` error: the borrowed expression implements the required traits --> crossbeam-epoch/src/internal.rs:212:17 | 212 | &|sealed_bag: &SealedBag| sealed_bag.is_expired(global_epoch), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(|sealed_bag: &SealedBag| sealed_bag.is_expired(global_epoch))` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow ```

``` warning: binary comparison to literal `Option::None` --> crossbeam-channel/tests/golang.rs:1050:20 | 1050 | if c.recv() != None { | ^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `c.recv().is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none = note: `#[warn(clippy::partialeq_to_none)]` on by default warning: binary comparison to literal `Option::None` --> crossbeam-channel/tests/golang.rs:1053:20 | 1053 | if c.try_recv() != None { | ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `c.try_recv().is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none ```

``` warning: passing a unit value to a function --> crossbeam-skiplist/benches/skiplist.rs:97:13 | 97 | black_box(map.remove(&num, guard).unwrap().release(guard)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `#[warn(clippy::unit_arg)]` on by default help: move the expression in front of the call and replace it with the unit literal `()` | 97 ~ map.remove(&num, guard).unwrap().release(guard); 98 ~ black_box(()); | ```

taiki-e · 2022-11-17T03:56:30Z

bors r+

927: Fix clippy::explicit_auto_deref warning r=taiki-e a=taiki-e ``` error: deref which would be done by auto-deref --> crossbeam-utils/src/sync/wait_group.rs:142:29 | 142 | let count: &usize = &*self.inner.count.lock().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner.count.lock().unwrap()` | = note: `-D clippy::explicit-auto-deref` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref ``` Co-authored-by: Taiki Endo <te316e89@gmail.com>

bors · 2022-11-17T03:58:42Z

Build failed:

test (aarch64-apple-darwin)

taiki-e · 2022-11-17T04:35:22Z

bors r+

bors · 2022-11-17T05:11:41Z

Build succeeded:

taiki-e added 3 commits November 17, 2022 12:52

taiki-e force-pushed the taiki-e/clippy branch from be41189 to f76c8b3 Compare November 17, 2022 03:56

taiki-e changed the title ~~Fix clippy::explicit_auto_deref warning~~ Fix newly added clippy warnings Nov 17, 2022

bors bot merged commit c840da4 into master Nov 17, 2022

bors bot deleted the taiki-e/clippy branch November 17, 2022 05:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix newly added clippy warnings #927

Fix newly added clippy warnings #927

taiki-e commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022

Fix newly added clippy warnings #927

Fix newly added clippy warnings #927

Conversation

taiki-e commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022

taiki-e commented Nov 17, 2022

bors bot commented Nov 17, 2022