Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log to crossdock.T #4

Open
HelloGrayson opened this issue Jun 28, 2016 · 1 comment
Open

Log to crossdock.T #4

HelloGrayson opened this issue Jun 28, 2016 · 1 comment

Comments

@HelloGrayson
Copy link

We should add the ability to log to crossdock.T similar to testing.T. For the normal case, that would just log to stdout, but for the crossdock test, we can wrap the testing.T into a crossdock.T, and log to the test object. This will make the tests silent except in case of failure or when we use -v.

@yurishkuro
Copy link
Contributor

@breerly it would also be nice to have a control var that would silence crossdock logging like below, even when running tests with -v. Maybe something similar to this: https://github.com/uber/jaeger-client-go/pull/37/files#diff-05d0732b45fb16a775bc3e5195a290aaR21

=== RUN   TestCrossdock
2016/09/01 19:52:59 HEAD http://127.0.0.1:54357/
2016/09/01 19:52:59 Client is ready, beginning test...
2016/09/01 19:52:59 HEAD http://127.0.0.1:54358/
2016/09/01 19:52:59 Client is ready, beginning test...
2016/09/01 19:52:59 GET http://127.0.0.1:54358/?behavior=trace&s1name=go&s2name=go&s2transport=http&s3name=go&s3transport=http&sampled=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants