This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
add: generate different css files with fontGear #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossjs
reviewed
Oct 29, 2018
index.js
Outdated
| var outputCSSFile = options.outputCSSFile || function (gear, clonedRoot) { | ||
| gear !== undefined && fs.writeFileSync(path.join(__dirname, 'test/fontGear/fontGear_' + gear +'.css'), clonedRoot, { | ||
| encoding: 'utf8' | ||
| }) |
There was a problem hiding this comment.
此处整个 function 的实现应该交给外部去定义，本组件只收配置，然后把 clone/walk 后的数据传给外面传入的 function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add: generate different css files with fontGear
more custom settings:
fontGear: array, default[-1, 0, 1, 2, 3, 4], the gears of font you want to useenableFontSetting: boolean, defaultfalse, whether to enable the fontSettingaddFontSizeToSelector:function, determines the logic when func adds fontSize to each declarationoutputCSSFile:function, determins how the plugin outputs the css file