Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the short reconciling interval problem when hitting a create issue #66

Closed
zzxwill opened this issue Apr 5, 2021 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@zzxwill
Copy link
Collaborator

zzxwill commented Apr 5, 2021

What problem are you facing?

When hitting an issue of creating an external resource, the reconciler interval is so short.

}
  Warning  CannotCreateExternalResource  4m49s  managed/project.sls.alibaba.crossplane.io  FailedToCreateSLSProject: {
    "httpCode": 400,
    "errorCode": "ProjectAlreadyExist",
    "errorMessage": "Project sls-project-test already exist",
    "requestID": "606B2B449A3FCDEBF04A39AB"
}
  Warning  CannotCreateExternalResource  4m49s  managed/project.sls.alibaba.crossplane.io  FailedToCreateSLSProject: {
    "httpCode": 400,
    "errorCode": "ProjectAlreadyExist",
    "errorMessage": "Project sls-project-test already exist",
    "requestID": "606B2B44C65D859813230B62"
}
  Warning  CannotCreateExternalResource  4m48s  managed/project.sls.alibaba.crossplane.io  FailedToCreateSLSProject: {
    "httpCode": 400,
    "errorCode": "ProjectAlreadyExist",
    "errorMessage": "Project sls-project-test already exist",
    "requestID": "606B2B456B5BF43B1BE88971"
}
  Warning  CannotCreateExternalResource  4m42s (x16 over 4m48s)  managed/project.sls.alibaba.crossplane.io  (combined from similar events): FailedToCreateSLSProject: {
    "httpCode": 400,
    "errorCode": "ProjectAlreadyExist",
    "errorMessage": "Project sls-project-test already exist",
    "requestID": "606B2B4B191163A6A2BA0214"
}

How could Crossplane help solve your problem?

Delete the requestID field from the error message.

@zzxwill zzxwill added the enhancement New feature or request label Apr 5, 2021
@muvaf
Copy link
Member

muvaf commented Apr 7, 2021

This should be solved after integrating a rate limiter from crossplane-runtime introduced in crossplane/crossplane-runtime#243

@zzxwill
Copy link
Collaborator Author

zzxwill commented Apr 7, 2021

@muvaf That's cool. I planed to implement it by remove requestID from the error. That would be more reasonable to solve in runtime level as requestID is an important field for issue debugging and keep high fidelity to cloud resource OpenAPI.

@muvaf
Copy link
Member

muvaf commented Apr 7, 2021

That'd be an additional step to take, which is something we're doing in provider-aws.

@zzxwill
Copy link
Collaborator Author

zzxwill commented Apr 8, 2021

@muvaf Great. I will upgrade this provider once the new release of runtime comes out. Closed it. Thanks.

@zzxwill zzxwill closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants