Add Labels from MR to Argocd AppProject #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
MisterMX
requested changes
Oct 25, 2023
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
|
@MisterMX can you take a look on it. I have made the change as requested. |
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
MisterMX
approved these changes
Nov 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This pull request introduces the capability for the argocd provider to support defining and adding labels to the ArgoCD AppProject from the MR. Labels in ArgoCD play a crucial role as they allow AppProjects to inherit default spec values from a global AppProject. Documentation link
Fixes #105
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
The code has been tested using a local setup where an ArgoCD project was created using the argocd provider. I verified: