Remove masterUserPasswordSecretRef as a required attribute

Signed-off-by: Javier Lopez <alcaraz1983@gmail.com>
crossplane-contrib · Mar 27, 2023 · 2c659fa · 2c659fa
1 parent f0163fa
commit 2c659fa
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/apis/rds/v1alpha1/custom_types.go b/apis/rds/v1alpha1/custom_types.go
@@ -193,8 +193,14 @@ type CustomDBClusterParameters struct {
 	// The password for the master database user. This password can contain any
 	// printable ASCII character except "/", """, or "@".
 	//
-	// Constraints: Must contain from 8 to 41 characters. Required.
-	MasterUserPasswordSecretRef *xpv1.SecretKeySelector `json:"masterUserPasswordSecretRef"`
+	// This parameter will be required in the following scenarios:
+	// - The first cluster for a global Aurora cluster
+	// - Any cluster as long as it doesn't belong to a global Aurora cluster
+	//
+	// This parameter is required for creation of a primary cluster. However, it is not required when attaching a secondary regional cluster to an existing global cluster.
+	//
+	// Constraints: Must contain from 8 to 41 characters.
+	MasterUserPasswordSecretRef *xpv1.SecretKeySelector `json:"masterUserPasswordSecretRef,omitempty"`
 
 	// A list of VPC security groups that the DB cluster will belong to.
 	//

diff --git a/package/crds/rds.aws.crossplane.io_dbclusters.yaml b/package/crds/rds.aws.crossplane.io_dbclusters.yaml
@@ -664,8 +664,13 @@ spec:
                   masterUserPasswordSecretRef:
                     description: "The password for the master database user. This
                       password can contain any printable ASCII character except \"/\",
-                      \"\"\", or \"@\". \n Constraints: Must contain from 8 to 41
-                      characters. Required."
+                      \"\"\", or \"@\". \n This parameter will be required in the
+                      following scenarios: - The first cluster for a global Aurora
+                      cluster - Any cluster as long as it doesn't belong to a global
+                      Aurora cluster \n This parameter is required for creation of
+                      a primary cluster. However, it is not required when attaching
+                      a secondary regional cluster to an existing global cluster.
+                      \n Constraints: Must contain from 8 to 41 characters."
                     properties:
                       key:
                         description: The key to select.
@@ -1090,7 +1095,6 @@ spec:
                     type: array
                 required:
                 - engine
-                - masterUserPasswordSecretRef
                 - region
                 type: object
               providerConfigRef: