Skip to content

Commit

Permalink
feat: switch to update method
Browse files Browse the repository at this point in the history
Signed-off-by: Romain Dauby <romain.dauby@gmail.com>
  • Loading branch information
r0mdau committed Sep 19, 2022
1 parent b3b0b27 commit 8f2c89d
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 43 deletions.
40 changes: 34 additions & 6 deletions pkg/controller/prometheusservice/rulegroupsnamespace/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (

"github.com/aws/aws-sdk-go/aws"
svcsdk "github.com/aws/aws-sdk-go/service/prometheusservice"
svcsdkapi "github.com/aws/aws-sdk-go/service/prometheusservice/prometheusserviceiface"
xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"
"github.com/crossplane/crossplane-runtime/pkg/connection"
"github.com/crossplane/crossplane-runtime/pkg/controller"
Expand Down Expand Up @@ -42,7 +43,8 @@ func SetupRuleGroupsNamespace(mgr ctrl.Manager, o controller.Options) error {
e.postDelete = postDelete
e.postObserve = postObserve
e.isUpToDate = isUpToDate
e.preUpdate = preUpdate
u := &updateClient{client: e.client}
e.update = u.update
},
}

Expand Down Expand Up @@ -156,10 +158,36 @@ func isUpToDate(cr *svcapitypes.RuleGroupsNamespace, resp *svcsdk.DescribeRuleGr
return true, nil
}

func preUpdate(ctx context.Context, cr *svcapitypes.RuleGroupsNamespace, obj *svcsdk.PutRuleGroupsNamespaceInput) error {
obj.WorkspaceId = cr.Spec.ForProvider.WorkspaceID
obj.Name = cr.Spec.ForProvider.Name
obj.Data = cr.Spec.ForProvider.Data
type updateClient struct {
client svcsdkapi.PrometheusServiceAPI
}

return nil
// GeneratePutRuleGroupsNamespaceInput returns a update input.
func GeneratePutRuleGroupsNamespaceInput(cr *svcapitypes.RuleGroupsNamespace) *svcsdk.PutRuleGroupsNamespaceInput {
res := &svcsdk.PutRuleGroupsNamespaceInput{}

if cr.Spec.ForProvider.Name != nil {
res.SetName(*cr.Spec.ForProvider.Name)
}
if cr.Spec.ForProvider.WorkspaceID != nil {
res.SetWorkspaceId(*cr.Spec.ForProvider.WorkspaceID)
}
if cr.Spec.ForProvider.Data != nil {
res.SetData(cr.Spec.ForProvider.Data)
}

return res
}

func (e *updateClient) update(ctx context.Context, mg resource.Managed) (managed.ExternalUpdate, error) {
cr, ok := mg.(*svcapitypes.RuleGroupsNamespace)
if !ok {
return managed.ExternalUpdate{}, errors.New(errUnexpectedObject)
}
input := GeneratePutRuleGroupsNamespaceInput(cr)
_, err := e.client.PutRuleGroupsNamespaceWithContext(ctx, input)
if err != nil {
return managed.ExternalUpdate{}, errors.Wrap(err, "update failed")
}
return managed.ExternalUpdate{}, nil
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8f2c89d

Please sign in to comment.