Merge pull request #1443 from MisterMX/fix/identityproviderconfig-retry

fix(eks/identityproviderconfig): Reset status field to retry create

pkg/controller/eks/identityproviderconfig/controller.go

@@ -111,7 +111,17 @@ func (e *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
 		},
 		ClusterName: &cr.Spec.ForProvider.ClusterName})
 	if err != nil {
-		return managed.ExternalObservation{}, awsclient.Wrap(resource.Ignore(eks.IsErrorNotFound, err), errDescribeFailed)
+		// Failed IdentityProviderConfigs will be garbage collected by AWS after
+		// some time.
+		// Since we are using cr.Status.AtProvider.Status in Create() to
+		// determine if we need to associate this fields needs to be reset if
+		// the config does not exist.
+		// Otherwise the controller will never retry associating again.
+		if eks.IsErrorNotFound(err) {
+			cr.Status.AtProvider.Status = ""
+			return managed.ExternalObservation{}, nil
+		}
+		return managed.ExternalObservation{}, awsclient.Wrap(err, errDescribeFailed)
 	}
 
 	current := cr.Spec.ForProvider.DeepCopy()

pkg/controller/eks/identityproviderconfig/controller_test.go

@@ -171,6 +171,23 @@ func TestObserve(t *testing.T) {
 				cr: identityProviderConfig(),
 			},
 		},
+		"NotFoundResetStatus": {
+			args: args{
+				eks: &fake.MockClient{
+					MockDescribeIdentityProviderConfig: func(ctx context.Context, input *awseks.DescribeIdentityProviderConfigInput, opts []func(*awseks.Options)) (*awseks.DescribeIdentityProviderConfigOutput, error) {
+						return nil, &awsekstypes.ResourceNotFoundException{}
+					},
+				},
+				cr: identityProviderConfig(
+					withStatus(manualv1alpha1.IdentityProviderConfigStatusCreateFailed),
+				),
+			},
+			want: want{
+				cr: identityProviderConfig(
+					withStatus(""),
+				),
+			},
+		},
 		"LateInitSuccess": {
 			args: args{
 				kube: &test.MockClient{