Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeGroupName and clusterControlPlaneSecurityGroup should be marked required #101

Closed
negz opened this issue Mar 27, 2019 · 2 comments
Closed

Comments

@negz
Copy link
Member

negz commented Mar 27, 2019

Is this a bug report or feature request? Bug Report

Deviation from expected behavior:
I expected to be able to create an EKSCluster without specifying a nodeGroupName or clusterControlPlaneSecurityGroup because they are not required by our CRD. When I attempt to create the cluster I see:

Status:
  Conditions:
    Last Transition Time:  2019-03-26T23:48:31Z
    Message:               
    Reason:                
    Status:                True
    Type:                  Creating
    Last Transition Time:  2019-03-27T00:02:47Z
    Message:               ValidationError: Parameters: [NodeGroupName, ClusterControlPlaneSecurityGroup] must have values
                           status code: 400, request id: a768a023-5023-11e9-91bf-ffa4977742d2
    Reason:                Failed to sync cluster state
    Status:                True
    Type:                  Failed

Expected behavior:
nodeGroupName and clusterControlPlaneSecurityGroup should remove the omitempty JSON tag so that they're marked as required in our generated CRD.

How to reproduce it (minimal and precise):

Environment:

$ kubectl -n crossplane-system describe deploy crossplane|grep Image
    Image:      crossplane/crossplane:v0.1.0-171.g3f13ae6

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-03-01T23:34:27Z", GoVersion:"go1.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:31:33Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

$ ./cluster/local/minikube.sh ssh
# ...
$ cat /etc/os-release 
NAME=Buildroot
VERSION=2018.05
ID=buildroot
VERSION_ID=2018.05
PRETTY_NAME="Buildroot 2018.05"

$ uname -a
Linux minikube 4.15.0 crossplaneio/crossplane#1 SMP Fri Jan 18 22:39:33 UTC 2019 x86_64 GNU/Linux
@displague displague transferred this issue from crossplane/crossplane Jan 9, 2020
namku pushed a commit to namku/provider-aws that referenced this issue Mar 9, 2021
…ic-provisioning

MySQL dynamic provisioning support for GCP CloudSQL and Azure MySQL Server
@haarchri
Copy link
Member

@negz think we can close this Issue ? With Cluster Resource we can create ControlPlane without specify both fields

https://doc.crds.dev/github.com/crossplane/provider-aws/eks.aws.crossplane.io/Cluster/v1beta1@v0.20.0#spec

@haarchri
Copy link
Member

haarchri commented Nov 6, 2021

close this issue - feel free to reopen if we have problems in current implementation

@haarchri haarchri closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants