Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic VPC creation failed to sync "CannotUpdateExternalResource" / ReconcileError #558

Closed
yesteph opened this issue Feb 23, 2021 · 0 comments · Fixed by #595
Closed

Basic VPC creation failed to sync "CannotUpdateExternalResource" / ReconcileError #558

yesteph opened this issue Feb 23, 2021 · 0 comments · Fixed by #595
Labels
bug Something isn't working

Comments

@yesteph
Copy link

yesteph commented Feb 23, 2021

What happened?

Creation of a basic VPC leads to a 'Ready' but 'Synced' = False status.
When I look at the description of my VPC resource in kubernetes, I see a lot of :

Warning  CannotUpdateExternalResource  18m  managed/vpc.ec2.aws.crossplane.io  failed to modify the VPC resource attributes: InvalidParameterCombination: No attributes specified.
           status code: 400, request id: c4fcc49d-c347-43fc-9e36-3b678db0f4d7
  Warning  CannotUpdateExternalResource  18m  managed/vpc.ec2.aws.crossplane.io  failed to modify the VPC resource attributes: InvalidParameterCombination: No attributes specified.
           status code: 400, request id: f01fd688-4f30-44f4-ad44-c3df826ace54
  Warning  CannotUpdateExternalResource  18m  managed/vpc.ec2.aws.crossplane.io  failed to modify the VPC resource attributes: InvalidParameterCombination: No attributes specified.
           status code: 400, request id: c027ed7e-0fda-4f7c-82d3-b25fcdacb835
  Warning  CannotUpdateExternalResource  18m  managed/vpc.ec2.aws.crossplane.io  failed to modify the VPC resource attributes: InvalidParameterCombination: No attributes specified.

How can we reproduce it?

cat <<EOF >> vpc.yaml
apiVersion: ec2.aws.crossplane.io/v1beta1
kind: VPC
metadata:
  name: crossplane-vpc-failed
spec:
  forProvider:
    region: eu-west-3
    cidrBlock: 10.0.0.0/16
EOF
kubectl apply -f vpc.yaml 

What environment did it happen in?

Crossplane version: 1.0.0
AWS Provider version: crossplane/provider-aws:v0.16.0
Kubernetes version: v1.20.0
Environment: minikube on MacOS

Additional information

Empty request to AWS

On the AWS side, I see Crossplane tries to call ec2.ModifyVpcAttribute without specifying any attribute.
The requestParameters only indicates a vpcId, nothing else.

Everything's fine with non-default values

I succeed to create a VPC if I indicate all the optional fields:

cat <<EOF >> vpc-ok.yaml
apiVersion: ec2.aws.crossplane.io/v1beta1
kind: VPC
metadata:
  name: crossplane-vpc-ok
spec:
  forProvider:
    region: eu-west-3
    cidrBlock: 10.0.0.0/16
    enableDnsHostNames: true
    enableDnsSupport: true
    instanceTenancy: default
    tags:
    - key: Name
      value: crossplane-vpc-ok
EOF
kubectl apply -f vpc-ok.yaml 
@yesteph yesteph added the bug Something isn't working label Feb 23, 2021
@yesteph yesteph changed the title Basic A Basic VPC creation failed to sync "CannotUpdateExternalResource" / ReconcileError Feb 23, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
Adding aws_ec2_instance_state, aws_ec2_network_insights_analysis, aws_ec2_transit_gateway_policy_table, aws_evidently_feature, aws_evidently_project, aws_evidently_segment, aws_fis_experiment_template, aws_glue_schema to v1beta1 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant