Unable to delete the CIDR Block after VPC is deleted

[AmnaIrfan]

What happened?

CIDR blocks are attached to VPCs so deleting a VPC in Crossplane automatically deletes the CIDR block in AWS. However the CIDR resource does not get deleted in Crossplane. The deletion gets stuck in a loop since AWS first tries to get the VPC and when the VPC doesn't exist it sends a VPC not found error while the code is waiting for a CIDR not found error.
We just need to account for the VPC not found error while deleting a CIDR block.

How can we reproduce it?

1. Create a VPC in Crossplane
2. Create a CIDR block for that VPC
3. Delete the VPC in Crossplane (it wont ask you to delete the CIDR block)
4. Delete the CIDR block in Crossplane (it will give an error that the VPC is not found)

What environment did it happen in?

Crossplane version:
def0bab

[muvaf]

Hi @AmnaIrfan! Looks like we need to return with ResourceExists: false here if the meta.WasDeleted(cr) is true and VPC cannot be found.

@AmnaIrfan Would you be interested in contributing this fix?

[AmnaIrfan]

@muvaf Yes I will be fix this today. Thank you!